Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

minor improvements #20

wants to merge 3 commits into from

Conversation

Stonelinks
Copy link

hey there,

just some small changes i found necessary when using this. thanks for the plugin!

@jk-gan jk-gan self-assigned this Jun 4, 2020
@jk-gan jk-gan added the enhancement New feature or request label Jun 4, 2020
Comment on lines +79 to +84
} catch (error) {
state.action = { type: action.type };
state.before = { error };
state.after = { error };
currentConnection.send('actionDispatched', state);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the error information in flipper is converted into another form of object which is not informative. I suggest to have one more field for the error message.

Suggested change
} catch (error) {
state.action = { type: action.type };
state.before = { error };
state.after = { error };
currentConnection.send('actionDispatched', state);
}
} catch (error) {
state.action = { type: action.type };
state.before = { error, message: error.toString() };
state.after = { error, message: error.toString() };
currentConnection.send('actionDispatched', state);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants