Shifting place to change token assignation to follow @weinong advice

jjournet · Aug 5, 2024 · 5b333d0 · 5b333d0
1 parent 57e918c
commit 5b333d0
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/pkg/internal/token/options.go b/pkg/internal/token/options.go
@@ -63,16 +63,13 @@ func GetSupportedLogins() string {
 }
 
 func NewOptions() Options {
-	env_TokenCacheDir := os.Getenv("KUBECACHEDIR")
+	if env_TokenCacheDir := os.Getenv("KUBECACHEDIR"); env_TokenCacheDir != "" {
+		DefaultTokenCacheDir = env_TokenCacheDir
+	}
 	return Options{
-		LoginMethod: DeviceCodeLogin,
-		Environment: defaultEnvironmentName,
-		TokenCacheDir: func() string {
-			if env_TokenCacheDir != "" {
-				return env_TokenCacheDir
-			}
-			return DefaultTokenCacheDir
-		}(),
+		LoginMethod:   DeviceCodeLogin,
+		Environment:   defaultEnvironmentName,
+		TokenCacheDir: DefaultTokenCacheDir,
 	}
 }