Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple warnings when a drums instrument can not be retrieved when loading a song (or MidiMix) #337

Closed
jjazzboss opened this issue Nov 13, 2022 · 0 comments
Closed

Multiple warnings when a drums instrument can not be retrieved when loading a song (or MidiMix) #337

jjazzboss opened this issue Nov 13, 2022 · 0 comments
Labels
bug Something isn't working
Milestone
4.0

Comments

@jjazzboss
Copy link
Owner

jjazzboss commented Nov 13, 2022 •
edited
Loading

When reading a MidiMix, if an instrument can't be retrieved, we use the "best" GM instrument instead. But nothing specific is done when it's an instrument for a drums channel, so we end up having a Piano on a drums channel. This can generate various issues.
@jjazzboss jjazzboss added the bug Something isn't working label Nov 13, 2022
@jjazzboss jjazzboss added this to the 4.0 milestone Nov 13, 2022
@jjazzboss jjazzboss changed the title Multiple warnings or errors when a drums instrument can not be retrieved when loading a song (or MidiMix) Multiple warnings when a drums instrument can not be retrieved when loading a song (or MidiMix) Nov 13, 2022
jjazzboss added a commit that referenced this issue Nov 13, 2022
@jjazzboss
Fix Issue #337 Multiple warnings when a drums instrument can not be r…
78513dd 
…etrieved when loading a song (or MidiMix)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@jjazzboss