revset: add remote function
#5450
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to find the remote bookmark tracked by a revset. It can be useful for diffing with the remote: `jj diff --from remote(@) --to @` Fixes: jj-vcs#4756
yuja
reviewed
Jan 24, 2025
Comment on lines
+375
to
+379
| if let Self::CommitRef(commit_ref) = commit_ref.borrow() { | ||
| Some(Rc::new(Self::CommitRef(RevsetCommitRef::Remote { | ||
| commit_ref: Box::new(commit_ref.clone()), | ||
| remote_pattern, | ||
| }))) |
There was a problem hiding this comment.
Ah, yes, it's correct that we can't support full range of revset expressions at the name resolution stage, but this is a big limitation I didn't notice before. We'll probably want to do remote(@-) or something, but x- can't be evaluated here. I have no idea how we can solve this problem.
We might need a language selecting bookmarks. Related: #5307
There was a problem hiding this comment.
Agreed. It would still be useful in that it allows you to create an alias that you can pass a specific bookmark name to, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to find the remote bookmark tracked by a revset.
It can be useful for diffing with the remote:
jj diff --from remote(@) --to @Fixes: #4756
Checklist
If applicable:
CHANGELOG.md