Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backout: include backed out commit's subject in new commit #3794

Merged
merged 3 commits into from
Jul 5, 2024
Merged

backout: include backed out commit's subject in new commit #3794

merged 3 commits into from
Jul 5, 2024

Conversation

bnjmnt4n
Copy link
Member

This is an alternative to #3583.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • [NA] I have updated the documentation (README.md, docs/, demos/)
  • [NA] I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@bnjmnt4n bnjmnt4n mentioned this pull request May 30, 2024
Closed
4 tasks
martinvonz
martinvonz reviewed May 30, 2024
View reviewed changes
lib/src/rewrite.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-osorqwynqkoo branch from 37c0890 to cc635f9 Compare May 30, 2024 19:52
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-osorqwynqkoo branch from cc635f9 to 1f903b3 Compare June 1, 2024 10:40
@bnjmnt4n bnjmnt4n changed the title backout: use git revert-style commit messages backout: include backed out commit's subject in new commit Jun 1, 2024
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-osorqwynqkoo branch from 1f903b3 to c1ee935 Compare July 3, 2024 12:53
@bnjmnt4n
Copy link
Member Author

bnjmnt4n commented Jul 3, 2024

Is there anything blocking this PR?

yuja
yuja approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

cli/src/commands/backout.rs Outdated Show resolved Hide resolved
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-osorqwynqkoo branch from c1ee935 to 6954a40 Compare July 4, 2024 09:07
@bnjmnt4n bnjmnt4n force-pushed the bnjmnt4n/push-osorqwynqkoo branch from 6954a40 to 39a2978 Compare July 5, 2024 07:54
@bnjmnt4n bnjmnt4n merged commit d2eb4d9 into main Jul 5, 2024
29 checks passed
@bnjmnt4n bnjmnt4n deleted the bnjmnt4n/push-osorqwynqkoo branch July 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice left review comments

@yuja yuja yuja approved these changes

@martinvonz martinvonz martinvonz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnjmnt4n @thoughtpolice @yuja @martinvonz