git_backend: on gc(), remove unreachable no-gc refs and compact them #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
force-pushed
the
push-wnzpqsmmsqty
branch
2 times, most recently
from
925da56 to
3605edc
Compare
yuja
force-pushed
the
push-wnzpqsmmsqty
branch
from
3605edc to
89fdf39
Compare
yuja
commented
Jan 26, 2024
|
Wait, did you send this 9 days ago!? Please don't hesitate to remind me to take a look at PRs if you haven't heard from me within two days or so. It might be that I'm just busy with other things, but it's probably more likely that I missed it (like in this case). |
The inner error should be the source, and I don't think the "Error:" prefix gives additional context.
The gc() implementation is likely to call other backend functions, which return BackendError.
… GIT_DIR Hopefully this will be more reliable on Windows where path/environment stuff is messy.
GitBackend::gc() will need to check if a commit is reachable from any historical operations. This could be calculated from the view and commit objects, but the Index will do a better job.
With my jj repo, the number of jj/keep refs went down from 87887 to 27733. The .git directory size is halved, but we'll need to clean up extra and index files to save disk space. "git gc --prune=now && jj debug reindex" passed, so the repo wouldn't be corrupted. jj-vcs#12
yuja
force-pushed
the
push-wnzpqsmmsqty
branch
from
89fdf39 to
1998e7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12
Checklist
If applicable:
CHANGELOG.md