Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Modern constraints #54

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Modern constraints #54

merged 2 commits into from
Jul 24, 2019

Conversation

saghul
Copy link
Member

@saghul saghul commented Jul 17, 2019

No description provided.

@saghul saghul marked this pull request as ready for review July 18, 2019 17:24
@saghul
Copy link
Member Author

saghul commented Jul 18, 2019

@paweldomas This is ready for review.

paweldomas
paweldomas previously approved these changes Jul 24, 2019
View reviewed changes
RTCUtil.js Outdated Show resolved Hide resolved
@saghul
api: use modern style constraints
e78b092 
Legacy constraints are still supported. This unlocks changing the
capture resolution and framerate.

In addition, proper createOffer / createAnswer options are implemented:
exposed as options in JS, but translated to constraints-style in native
since that's what the Java and Objective-C APIs have to offer.
@saghul
Copy link
Member Author

saghul commented Jul 24, 2019

@paweldomas Updated, PTAL.

@saghul saghul merged commit 1929018 into master Jul 24, 2019
@saghul saghul deleted the modern-constraints branch October 2, 2019 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paweldomas paweldomas paweldomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @paweldomas