Moving conference init to react #1196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idainatovych
force-pushed
the
moving-conference-init-to-react
branch
from
d819097 to
0ec43f5
Compare
idainatovych
force-pushed
the
moving-conference-init-to-react
branch
from
0ec43f5 to
b245802
Compare
|
Superseded by #1201. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of moving conference and app logic to the React app. There I moved
initmethod fromapp.jsto new app. Now application defines its current state via React Router instead of direct checking of browser location. Connection and disconnection from the call are also being triggered by actions.