Update api.md #1180
Merged
Update api.md #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix videoConferenceJoined and videoConferenceLeft event names
luixxiul
added
api
jallamsetty1
added a commit
to jallamsetty1/jitsi-meet
that referenced
this pull request
Jun 1, 2021
* fix(LocalSdpMunger): Fix unit test. * fix(CodecSelection): Call RTCRtpTransceiver#setCodecPreferences before renegotiation. Call RTCRtpTransceiver#setCodecPreferences with the preferrred codec order before every createOffer/createAnswer. This ensures that the codec preference is enforced even when there is no local description available yet while the preferred codec is being set immediately after media session creation. * fix(JingleSessionPC): Add a workaround for chrome issue. The 'signalingstatechange' event for 'stable' is fired after the 'iceconnectionstatechange' event for 'completed' is fired on chrome in Unified plan. This prevents the client from switching the media connection to the p2p connection once the ice connection for p2p gets established. * fix(Logging): Log enhancements. Add a preifx to logs for idenitifying the type of TPC/jingleSessionPC. * feat(TPC): Enable unified-plan support for Chromium based browsers. This can be controlled through the config.js option 'enableUnifiedOnChrome'. * fix(TPC): Do not configure encodings on Safari until reneg. Avoid configuring the encodings on Chromium/Safari until simulcast is configured for the newly added track using SDP munging which happens during the renegotiation. * fix(TPC): Do not configure encodings on chromium immediately after replace track. Avoid configuring the encodings on chromium immediately after replace track since the encoding params are read-only until the renegotation is done. * fix: send json message (jitsi#1180) jitsi/lib-jitsi-meet@be3e2a6...3fb44f7
jallamsetty1
added a commit
that referenced
this pull request
Jun 1, 2021
* fix(LocalSdpMunger): Fix unit test. * fix(CodecSelection): Call RTCRtpTransceiver#setCodecPreferences before renegotiation. Call RTCRtpTransceiver#setCodecPreferences with the preferrred codec order before every createOffer/createAnswer. This ensures that the codec preference is enforced even when there is no local description available yet while the preferred codec is being set immediately after media session creation. * fix(JingleSessionPC): Add a workaround for chrome issue. The 'signalingstatechange' event for 'stable' is fired after the 'iceconnectionstatechange' event for 'completed' is fired on chrome in Unified plan. This prevents the client from switching the media connection to the p2p connection once the ice connection for p2p gets established. * fix(Logging): Log enhancements. Add a preifx to logs for idenitifying the type of TPC/jingleSessionPC. * feat(TPC): Enable unified-plan support for Chromium based browsers. This can be controlled through the config.js option 'enableUnifiedOnChrome'. * fix(TPC): Do not configure encodings on Safari until reneg. Avoid configuring the encodings on Chromium/Safari until simulcast is configured for the newly added track using SDP munging which happens during the renegotiation. * fix(TPC): Do not configure encodings on chromium immediately after replace track. Avoid configuring the encodings on chromium immediately after replace track since the encoding params are read-only until the renegotation is done. * fix: send json message (#1180) jitsi/lib-jitsi-meet@be3e2a6...3fb44f7
pull bot
pushed a commit
to e4basil/jitsi-meet
that referenced
this pull request
Jun 1, 2021
* fix(LocalSdpMunger): Fix unit test. * fix(CodecSelection): Call RTCRtpTransceiver#setCodecPreferences before renegotiation. Call RTCRtpTransceiver#setCodecPreferences with the preferrred codec order before every createOffer/createAnswer. This ensures that the codec preference is enforced even when there is no local description available yet while the preferred codec is being set immediately after media session creation. * fix(JingleSessionPC): Add a workaround for chrome issue. The 'signalingstatechange' event for 'stable' is fired after the 'iceconnectionstatechange' event for 'completed' is fired on chrome in Unified plan. This prevents the client from switching the media connection to the p2p connection once the ice connection for p2p gets established. * fix(Logging): Log enhancements. Add a preifx to logs for idenitifying the type of TPC/jingleSessionPC. * feat(TPC): Enable unified-plan support for Chromium based browsers. This can be controlled through the config.js option 'enableUnifiedOnChrome'. * fix(TPC): Do not configure encodings on Safari until reneg. Avoid configuring the encodings on Chromium/Safari until simulcast is configured for the newly added track using SDP munging which happens during the renegotiation. * fix(TPC): Do not configure encodings on chromium immediately after replace track. Avoid configuring the encodings on chromium immediately after replace track since the encoding params are read-only until the renegotation is done. * fix: send json message (jitsi#1180) jitsi/lib-jitsi-meet@be3e2a6...3fb44f7
lalayueh
pushed a commit
to lalayueh/jitsi-meet
that referenced
this pull request
Jun 6, 2021
* fix(LocalSdpMunger): Fix unit test. * fix(CodecSelection): Call RTCRtpTransceiver#setCodecPreferences before renegotiation. Call RTCRtpTransceiver#setCodecPreferences with the preferrred codec order before every createOffer/createAnswer. This ensures that the codec preference is enforced even when there is no local description available yet while the preferred codec is being set immediately after media session creation. * fix(JingleSessionPC): Add a workaround for chrome issue. The 'signalingstatechange' event for 'stable' is fired after the 'iceconnectionstatechange' event for 'completed' is fired on chrome in Unified plan. This prevents the client from switching the media connection to the p2p connection once the ice connection for p2p gets established. * fix(Logging): Log enhancements. Add a preifx to logs for idenitifying the type of TPC/jingleSessionPC. * feat(TPC): Enable unified-plan support for Chromium based browsers. This can be controlled through the config.js option 'enableUnifiedOnChrome'. * fix(TPC): Do not configure encodings on Safari until reneg. Avoid configuring the encodings on Chromium/Safari until simulcast is configured for the newly added track using SDP munging which happens during the renegotiation. * fix(TPC): Do not configure encodings on chromium immediately after replace track. Avoid configuring the encodings on chromium immediately after replace track since the encoding params are read-only until the renegotation is done. * fix: send json message (jitsi#1180) jitsi/lib-jitsi-meet@be3e2a6...3fb44f7
sandeepjangir
pushed a commit
to shahidtumbi/jitsi-meet
that referenced
this pull request
Jan 6, 2022
* fix(LocalSdpMunger): Fix unit test. * fix(CodecSelection): Call RTCRtpTransceiver#setCodecPreferences before renegotiation. Call RTCRtpTransceiver#setCodecPreferences with the preferrred codec order before every createOffer/createAnswer. This ensures that the codec preference is enforced even when there is no local description available yet while the preferred codec is being set immediately after media session creation. * fix(JingleSessionPC): Add a workaround for chrome issue. The 'signalingstatechange' event for 'stable' is fired after the 'iceconnectionstatechange' event for 'completed' is fired on chrome in Unified plan. This prevents the client from switching the media connection to the p2p connection once the ice connection for p2p gets established. * fix(Logging): Log enhancements. Add a preifx to logs for idenitifying the type of TPC/jingleSessionPC. * feat(TPC): Enable unified-plan support for Chromium based browsers. This can be controlled through the config.js option 'enableUnifiedOnChrome'. * fix(TPC): Do not configure encodings on Safari until reneg. Avoid configuring the encodings on Chromium/Safari until simulcast is configured for the newly added track using SDP munging which happens during the renegotiation. * fix(TPC): Do not configure encodings on chromium immediately after replace track. Avoid configuring the encodings on chromium immediately after replace track since the encoding params are read-only until the renegotation is done. * fix: send json message (jitsi#1180) jitsi/lib-jitsi-meet@be3e2a6...3fb44f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix videoConferenceJoined and videoConferenceLeft event names