Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Titlebar on Gnome-Wayland run natively #683

Closed
9Lukas5 opened this issue Dec 4, 2021 · 8 comments · Fixed by #766
Closed

No Titlebar on Gnome-Wayland run natively #683

9Lukas5 opened this issue Dec 4, 2021 · 8 comments · Fixed by #766

Comments

@9Lukas5
Copy link

9Lukas5 commented Dec 4, 2021

Description

Running Jitsi in Wayland native on Gnome doesn't have Window decorator, as Gnome-Wayland doesn't support this at the moment.
This is related to the electron upstream issue electron/electron#27522 , but no idea how long it would take the upstream issue get's closed and then taking effect for Jitsi.


Current behavior

Running Jitsi in Wayland native under Gnome results in the window not having a titlebar.
Possible to fully use and move around with Super+Mouse Click&Drag.


Expected Behavior

Having Window decorator on Gnome when running in Wayland native


Possible Solution

Add custom decorator, or wait what electron does upstream


Steps to reproduce

Run in a Gnome-Wayland session with

<path to bin> --enable-features=UseOzonePlatform --ozone-platform=wayland

Environment details

Ubuntu 20.04 Focal Fossa
Gnome 41 on Wayland
Jitsi 2021.11.2


@saghul
Copy link
Member

saghul commented Dec 4, 2021

This is not something we can solve, and having this issue open while Electron itself doesn't support won't help either.

When electron gets it we'll update.

@saghul saghul closed this as completed Dec 4, 2021
@9Lukas5
Copy link
Author

9Lukas5 commented Dec 4, 2021

Well, can not is maybe the wrong wording, as for example VSCode has an setting to enable client side decorations, as I found out here.

So the question would be more of is it worth the work, implementing something or waiting on what/when it changes in electron upstream^^

Jitsi doesn't have any menus, so it would basically only a simple bar, holding the buttons for minimize, maximize and close.

@csett86
Copy link
Member

csett86 commented Dec 4, 2021

Upstream electron is nearly ready with client side decorations, so I suggest that we hold off here and wait for that: electron/electron#29618

@snaggen
Copy link

snaggen commented May 30, 2022

The electron PR is merged, but I still do not see any borders when using native wayland....

@saghul
Copy link
Member

saghul commented May 30, 2022

Try passing this argument: --enable-features=WaylandWindowDecorations

@snaggen
Copy link

snaggen commented May 30, 2022

That worked! Thanks!

@saghul
Copy link
Member

saghul commented May 30, 2022

@csett86 Not sure how risky it would be to enable this by default...

csett86 added a commit that referenced this issue Jul 3, 2022
Use with --ozone-platform=wayland to enable

Closes: #683
csett86 added a commit that referenced this issue Jul 3, 2022
Use with --ozone-platform=wayland to enable

Closes: #683
@csett86
Copy link
Member

csett86 commented Jul 3, 2022

Enabling by default at least under Ubuntu 22.04 (with wayland) causes issues, so I'd rather not do that by default:

grafik

csett86 added a commit that referenced this issue Aug 12, 2022
Use with --ozone-platform-hint=auto to enable

Closes: #683
d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this issue Sep 1, 2023
Use with --ozone-platform-hint=auto to enable

Closes: jitsi#683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants