Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POLL: Should the avatar go? #379

Closed
saghul opened this issue Jun 3, 2020 · 0 comments · Fixed by #385
Closed

POLL: Should the avatar go? #379

saghul opened this issue Jun 3, 2020 · 0 comments · Fixed by #385
Labels
question Not an issue but a question

Comments

@saghul
Copy link
Member

saghul commented Jun 3, 2020

Since this repo has a small (but enthusiastic) group of individuals, let's try this.

There is a disconnect between the avatar displayed in the app and what the web would use, should you use a browser. Since we are already asking for a username and email, the embedded jitsi meet will already know to use gravatar or the locally generated avatar, or whatever is configured.

There is no good way to embed the avatar logic in Jitsi Meet here.

So I'm thinking of getting rid of it from the UI here. Thoughts? Please vote with 👍 or 👎 and leave a comment if you need to elaborate.
@Echolon Echolon added the question Not an issue but a question label Jun 3, 2020
saghul added a commit to saghul/jitsi-meet-electron that referenced this issue Jun 4, 2020
@saghul
Remove local avatar
c255b27 
The deployment will generate the right one based on the provided name
and email.

Fixes: jitsi#379
@saghul saghul mentioned this issue Jun 4, 2020
Merged
saghul added a commit that referenced this issue Jun 4, 2020
@saghul
Remove local avatar
8de41a4 
The deployment will generate the right one based on the provided name
and email.

Fixes: #379
d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this issue Sep 1, 2023
@saghul
Remove local avatar
4c54778 
The deployment will generate the right one based on the provided name
and email.

Fixes: jitsi#379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Not an issue but a question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove local avatar saghul/jitsi-meet-electron
2 participants
@saghul @Echolon