This repository has been archived by the owner on Mar 27, 2018. It is now read-only.
Fixes & autostart functionality #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
! Custom duration values are not supported for Toasts ! <uses-*>-tags have to appear before <application> in AndroidManifest.xml ! Attribute "android:editable" of <EditText> is deprecated ! Converted smileys from gif to png ! Use "Integer.valueOf()" instead of "new Integer()" ! <LinearLayout> was missing explicit orientation-tag + Added a lint.xml to suppress unnecessary warnings * Ignore "Suspicious0dp"-Warning in contact_list.xml ! recycle TypedArrays after use ! explicitly use Locale.US when creating a SimpleDateFormat ! removed invalid layout parameter "layout_column" from TextView in account_list_row.xml ! layout_below is useless in a LinearLayout ! Specify inputType in chat_typing_area.xml There are still a lot of warnings left, I only fixed things I could test.
|
It is not really my place to say this. I am not a maintainer of any kind and I have no affiliation (excluding the CLA) whatsoever to the Jitsi Organization. Since that is so, I can be wrong on some or all of the points I'm raising. That being said: I think there are several problems with this pull request.
|
|
I (netmackan) have signed the CLA long time ago when contributing some stuff to Jitsi. |
|
Same here, I signed the CLA a long time ago.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I probably won't be doing any jitsi-android development anytime soon, I decided to open this pull request to give back some of the improvements I made.
Each commit falls into one of these categories:
The commits were tested and do work, a prebuilt apk is currently available at http://thrimbor.github.io/jitsi-builds/jitsi_2014-11-10.apk
I ran this build on my phone for months and still have it installed.
Please feel free to leave out individual commits if you want, I just wanted to offer you these changes because I will be deleting my jitsi-android fork soon (because, as I said, I won't be working on it anytime soon).