Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add monochrome icon #96

Closed
xmha97 opened this issue Apr 14, 2023 · 12 comments
Closed

[Feature Request]: Add monochrome icon #96

xmha97 opened this issue Apr 14, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@xmha97
Copy link

xmha97 commented Apr 14, 2023

Please support the Android 13 "Themed App Icons" feature.

Screenshot_2023-04-14-07-52-45-256_de.mm20.launcher2.release.jpg

@xmha97 xmha97 added the enhancement New feature or request label Apr 14, 2023
@jithware
Copy link
Owner

@xmha97
Copy link
Author

xmha97 commented Apr 17, 2023

I think it's possible.
Aves is a Flutter app and has the monochrome icon.

@jithware
Copy link
Owner

Brethap currently uses flutter_launcher_icons to generate app icons. At the moment it doesn't support generating monochrome icons (see fluttercommunity/flutter_launcher_icons#419). I'll look into manually adding them. It would be preferable to use flutter_launcher_icons in the future.

@jithware
Copy link
Owner

jithware commented Apr 17, 2023

@xmha97 I found this article to manually add them: add-android-themed-icon-support-to-your-flutter-app. It doesn't look to bad. Do you want to implement it and submit a pull request?

@xmha97
Copy link
Author

xmha97 commented Apr 17, 2023

@xmha97 I found this article to manually add them: add-android-themed-icon-support-to-your-flutter-app. It doesn't look to bad. Do you want to implement it and submit a pull request?

Sorry, I'm not a programmer.

@jithware
Copy link
Owner

Your profile says you have skills in c# and you love coding for fun. This update would just be adding the images and editing xml. I can update your pull request if there are any problems.

@xmha97
Copy link
Author

xmha97 commented Apr 17, 2023

Your profile says you have skills in c# and you love coding for fun.

:)))

This update would just be adding the images and editing xml. I can update your pull request if there are any problems.

OK, please check this PR: #97

@jithware
Copy link
Owner

Tried running the pull request on an emulator with API 33 and getting:

AAPT: error: resource drawable/ic_launcher_background (aka com.jithware.brethap:drawable/ic_launcher_background) not found.

I'll have to look a little deeper into adding monochrome.

jithware added a commit that referenced this issue Apr 18, 2023
@jithware
Copy link
Owner

I believe I got it working. The "B" is a little bigger now due to clipping of adaptive icons, but seems to work:

snapshot1
snapshot2

@jithware
Copy link
Owner

@xmha97 any chance you are fluent in the native langauge of Iran? If so, are you interested in adding it to Brethap? This way Brethap can be added to the Play Store for Iran. Here's a howto if you are interested.

@jithware
Copy link
Owner

In release >= 1.7.16+104

@xmha97
Copy link
Author

xmha97 commented May 14, 2023

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants