Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💯おリファクタリングしましたわ✨✨ #49

Merged
merged 7 commits into from
Jun 25, 2022

Conversation

jiro4989
Copy link
Owner

おリファクタリングですわ!

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #49 (f6016c6) into main (57a15f2) will increase coverage by 0.05%.
The diff coverage is 92.73%.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   94.90%   94.95%   +0.05%     
==========================================
  Files           4        5       +1     
  Lines         491      496       +5     
==========================================
+ Hits          466      471       +5     
  Misses         20       20              
  Partials        5        5              
Impacted Files Coverage Δ
convert_condition.go 88.88% <88.88%> (ø)
convert_rule.go 100.00% <100.00%> (ø)
internal/chars/chars.go 91.22% <100.00%> (ø)
ojosama.go 97.38% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d369cfa...f6016c6. Read the comment docs.

@jiro4989 jiro4989 changed the title 💯お変数名の変更とおファイルの分割をしましたわ✨ 💯おリファクタリングしましたわ✨✨ Jun 25, 2022
@jiro4989 jiro4989 merged commit 1945a5f into main Jun 25, 2022
@jiro4989 jiro4989 deleted the chore/refactor-2 branch June 25, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant