Replaced $timeout by $interval to allow tests with protractor. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e default issue here : angular/protractor#169
|
Hi, It also seems like a trivial change. Can we merge it? PS: Github diff shows like too much is changed, but when I check it at the Webstorm, they are mostly space changes. What changed is the $timeout -> $interval @cmourouvin : it might be better, if you leave the spaces, so that what really changed might be better reflected |
|
Hi, Thanks for the PR! I did as you proposed:) BR, |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the default issue here : angular/protractor#169
In protractor you can't test message in the toast when you have 'timeout' enabled for it. Protractor is waiting for the timeout to finish to continue and you test is usually after the error display.