Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JeongJiHwan
temporarily deployed
to
development
GitHub Actions
Inactive
scarf005
requested changes
Aug 17, 2023
There was a problem hiding this comment.
작성하시느라 수고 많으셨어요! 다만 zod의 객체 메서드들을 사용하면 중복되는 코드를 많이 줄일 수 있을 것 같아요. 또, 상태값의 경우에는 숫자 대신 리터럴 유니언 타입을 사용하면 좀 더 명확하게 의도를 전달할 수 있을 것 같아요.
또 궁금한 점이 있다면 언제라도 답글을 달아주세요!
Comment on lines
+39
to
+48
| export const createBookBodySchema = z.object({ | ||
| title: z.string(), | ||
| isbn: z.string(), | ||
| author: z.string(), | ||
| publisher: z.string(), | ||
| image: z.string(), | ||
| categoryId: z.string(), | ||
| pubdate: z.string(), | ||
| donator: z.string(), | ||
| }); |
There was a problem hiding this comment.
createBookBodySchema와 updateBookBodySchema는 모두 bookInfoSchema에서 조금씩만 변형된 형태입니다. 그렇다면 zod의 .pick()과 .omit()을 써보면 어떨까요?
There was a problem hiding this comment.
zod의 기능을 전혀 활용하지 못하고 있었네요 ㅎ.. 확인해보겠습니다!
There was a problem hiding this comment.
book, bookinfo, book&bookinfo 등 아직 정리가 되지 않아서 이후 api 구현하면서 수정해보도록 하겠습니다.
JeongJiHwan
temporarily deployed
to
development
GitHub Actions
Inactive
|
뒤늦게 지정도서가 뭔지 기억났습니다. |
JeongJiHwan
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
books api 스펙 contracts 정리
작업 사항
get: books/info/search
get: books/info/tag
get: books/info -> /books/info/sorted
get: books/info/:id
get: books/search
get: books/create
get: books/:bookId
post: books/create
patch: books/update
patch: books/donator