-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kysely 적용 #670
Merged
feat: kysely 적용 #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeongJiHwan
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typeorm 에서 kysely로 변경되는 내용들 확인했습니다.
JeongJiHwan
pushed a commit
that referenced
this pull request
Aug 25, 2023
* build: ts-rest와 zod 버전 업데이트 * build: kysely 추가 * feat: db 타입 생성 및 kysely 연결 * feat: 타입 안전한 date 함수 래퍼 * refactor: `v2/reviews`에 kysely 적용 --------- Co-authored-by: nocontribute <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
https://github.com/orgs/jiphyeonjeon-42/discussions/9#discussioncomment-6677350
작업 사항
변경점
ts-rest
버전 업데이트v2/reviews
에서 kysely 사용목적
raw query를 타입 안전하게 변경