-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
users api 스펙 정리 #654
Merged
The head ref may contain hidden characters: "650-users-api-\uC2A4\uD399-\uC815\uB9AC"
Merged
users api 스펙 정리 #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users GET API contract 추가
400, 500 에러 시 공용으로 사용할 에러 스키마 추가
searchUser의 query 용도의 스키마 추가
- searchUser의 200 response 스키마 추가 - 200 response의 reservations 스키마 추가 - 200 response의 lendings 스키마 추가
스키마에서 nullable()을 optional()로 변경
eslint 적용하여 코드 포맷팅
페이지네이션에 필요한 metaSchema shared.ts에 추가
searchUserResponseSchema 내 reservations, lendings는 []를 반환할 수 있도록 배열 내 오브젝트가 optional임을 명시함
Closed
- 유저 생성 contract 추가 - pathprefix 추가
createUsers의 request body에 들어갈 스키마 추가
user를 업데이트하는 patch 메서드 contract에 추가
- update user에 필요한 스키마 정의 - 스키마 파일 리팩토링
- 필요한 스키마 import - 200 response 스키마 변경
path에서 누락된 / 추가
userIdSchema의 키를 userId에서 id로 변경
라우터 내 키 변경
개인정보 변경하는 myupdate API 추가
myupdate에 사용할 request body, response 스키마 추가
공용으로 사용할 403 에러의 스키마 추가
scarf005
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
users API 스펙 contracts에 정리
작업 사항
/api/users/search
/api/users/create
api/users/update/{id}
api/users/myupdate
api/users/EasterEgg