Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nginx에서 swagger/swagger-v2/ 경로 허용 #640

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Aug 2, 2023

개요

image

배포 서버에서 v1과 v2 swagger 문서를 볼 수 있게 수정합니다.

변경점

일관성을 위해 /docs 경로명을 /swagger-v2로 변경했습니다.

작업 사항

  1. nginx 설정 파일에서 /swagger-v2/ 경로를 노출했습니다.
  2. swagger.jsondocs.json의 경로를 swagger/openapi.jsonswagger-v2/openapi.json으로 변경했습니다.

/swagger/swagger-v2 경로를 나눈 이유

/swagger/v2 경로를 사용해 nginx 설정 중복을 피하려 했으나 v1 swagger 경로와 겹쳐 사용이 불가능해 경로를 2개 사용해야 했습니다.

@scarf005 scarf005 temporarily deployed to development August 2, 2023 12:48 — with GitHub Actions Inactive
@jimin52
Copy link
Member

jimin52 commented Aug 3, 2023

/swagger /docs 보다는 /swagger /swagger-v2 가 일관성 측면에서 낫지 않을까요?

@scarf005 scarf005 force-pushed the swagger-경로-허용 branch from 957c77c to ee12b7f Compare August 3, 2023 06:22
@scarf005 scarf005 temporarily deployed to development August 3, 2023 06:22 — with GitHub Actions Inactive
@scarf005 scarf005 changed the title fix: nginx에서 swagger/docs/ 경로 허용 fix: nginx에서 swagger/swagger-v2/ 경로 허용 Aug 3, 2023
@scarf005 scarf005 requested a review from jimin52 August 3, 2023 06:49
Copy link
Member

@jimin52 jimin52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scarf005 scarf005 merged commit 741d001 into develop Aug 3, 2023
@scarf005 scarf005 deleted the swagger-경로-허용 branch August 3, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

swagger 접속이 불가능합니다
2 participants