Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 기부자 수정 api #593

Merged
merged 3 commits into from
Aug 13, 2023
Merged

feat: 기부자 수정 api #593

merged 3 commits into from
Aug 13, 2023

Conversation

jimin52
Copy link
Member

@jimin52 jimin52 commented Jul 20, 2023

개요

donator 를 업데이트하는 api 추가

작업 사항

PATCH /api/books/donator endpoint 추가

목적

온보딩 api 생성해보기

JeongJiHwan and others added 2 commits July 20, 2023 10:42
add authValidate, modify api endpoint, build test
@jimin52 jimin52 linked an issue Jul 20, 2023 that may be closed by this pull request
5 tasks
Copy link

@mink97 mink97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿입니다.

Comment on lines +416 to +418
} else {
return next(new ErrorResponse(errorCode.INVALID_INPUT, status.BAD_REQUEST));
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

donator 가 존재하지 않는 유저인 경우에 추가할 수 있으면 좋을 것 같습니다.

@jimin52 jimin52 marked this pull request as draft July 20, 2023 02:08
@jimin52
Copy link
Member Author

jimin52 commented Jul 20, 2023

swagger 도 추가해야 합니다

@scarf005 scarf005 changed the title 592 add donator update api feat: 기부자 수정 api Jul 20, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

backend/src/v1/books/books.controller.ts Show resolved Hide resolved
backend/src/v1/books/books.controller.ts Show resolved Hide resolved
@scarf005 scarf005 self-requested a review August 9, 2023 07:37
@scarf005 scarf005 marked this pull request as ready for review August 9, 2023 07:37
@scarf005 scarf005 self-assigned this Aug 9, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scarf005 scarf005 merged commit 2e4b534 into develop Aug 13, 2023
@scarf005 scarf005 deleted the 592-add-donator-update-api branch August 13, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

add donator update api
4 participants