Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migration 제거 #565

Merged
merged 4 commits into from
Jul 9, 2023
Merged

build: migration 제거 #565

merged 4 commits into from
Jul 9, 2023

Conversation

jimin52
Copy link
Member

@jimin52 jimin52 commented Jul 9, 2023

migration 제거

  • ci: working-directory 사용

  • build: migration 제거

실사용되지 않는 패키지여서 제거하였습니다.

  • ci: 빌드 시간 제한시간 완화

배포시 도커 컴포즈 빌드 시간이 오래 걸려 실패하는 경우를 방지합니다.

* ci: working-directory 사용

* build: migration 제거

실사용되지 않는 패키지여서 제거하였습니다.

* ci: 빌드 시간 제한시간 완화

배포시 도커 컴포즈 빌드 시간이 오래 걸려 실패하는 경우를 방지합니다.
@scarf005 scarf005 requested a review from YeonSeong-Lee July 9, 2023 07:01
scarf005
scarf005 previously approved these changes Jul 9, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scarf005
scarf005 previously approved these changes Jul 9, 2023
* refactor: if문 제거

map과 foreach는 배열이 비어있어도 동작에 영향을 주지 않으므로 제거

* refactor: reduce 사용

* refactor: 객체 변경을 피함

* refactor: 변수명 통일

사용자 명칭이 user와 item으로 다르게 불리던 것을 user로 통일

* refactor: 메서드명을 동작과 일치하게 변경

실제로 유저를 변경하지 않고 대여 기록과 함께 반환하므로

* docs: 메서드 설명 추가
YeonSeong-Lee
YeonSeong-Lee previously approved these changes Jul 9, 2023
Copy link
Member

@YeonSeong-Lee YeonSeong-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users.service.ts 가 들어간 부분을 제외하고 다른 부분 확인 완료했습니다.

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG?TM

@jimin52 jimin52 merged commit a98f00d into main Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants