Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /Users endpoint 작성 #79

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: /Users endpoint 작성 #79

wants to merge 17 commits into from

Conversation

parkj12b
Copy link
Contributor

Closes #72

@parkj12b parkj12b added the enhancement New feature or request label Dec 15, 2024
@parkj12b parkj12b self-assigned this Dec 15, 2024
@parkj12b parkj12b requested a review from jimin52 December 15, 2024 05:05
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 31.83857% with 152 lines in your changes missing coverage. Please review.

Project coverage is 57.30%. Comparing base (12be539) to head (871f052).

Files with missing lines Patch % Lines
backend/src/users/users.service.ts 16.04% 57 Missing and 11 partials ⚠️
backend/src/users/users.controller.ts 24.65% 47 Missing and 8 partials ⚠️
backend/src/common/utils/paginate.utils.ts 18.18% 9 Missing ⚠️
backend/src/common/utils/utils.ts 27.27% 7 Missing and 1 partial ⚠️
backend/src/users/mockdata/users.mockdata.ts 0.00% 6 Missing ⚠️
backend/src/app.module.ts 0.00% 2 Missing ⚠️
backend/src/users/users.module.ts 0.00% 2 Missing ⚠️
backend/src/config.ts 0.00% 1 Missing ⚠️
backend/src/users/schema/users.schema.ts 95.65% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #79       +/-   ##
===========================================
+ Coverage   11.59%   57.30%   +45.71%     
===========================================
  Files          48       54        +6     
  Lines         664      855      +191     
  Branches        0       33       +33     
===========================================
+ Hits           77      490      +413     
+ Misses        587      345      -242     
- Partials        0       20       +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

backend/src/users/users.service.ts Outdated Show resolved Hide resolved
backend/src/users/users.service.ts Outdated Show resolved Hide resolved
backend/src/users/mockdata/users.mockdata.ts Outdated Show resolved Hide resolved
backend/src/common/utils/utils.ts Show resolved Hide resolved
backend/src/users/users.service.ts Outdated Show resolved Hide resolved
@scarf005 scarf005 changed the title /Users endpoint 작성 feat: /Users endpoint 작성 Dec 15, 2024
.env.example Outdated Show resolved Hide resolved
backend/src/common/utils/paginate.utils.ts Outdated Show resolved Hide resolved
backend/src/common/dto/dto.ts Outdated Show resolved Hide resolved
backend/src/common/schema/schema.ts Outdated Show resolved Hide resolved
backend/src/users/users.service.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author

@parkj12b parkj12b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case insensitive 해야하는 이유가 있나요?

url 은 lower case 를 많이써서 case insesntivie 해야 하는줄 알았는데 그게 아니었네요

@parkj12b parkj12b requested a review from jimin52 December 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/Users
3 participants