Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use start_as_current_span to maintain tracing operation chain #5391

Merged
merged 8 commits into from
Nov 15, 2022

Conversation

girishc13
Copy link
Contributor

@girishc13 girishc13 commented Nov 14, 2022

Goals:

Before:
before-start-as-current-span

After:

after-start-as-span

@girishc13 girishc13 self-assigned this Nov 14, 2022
@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Nov 14, 2022
jina/serve/executors/__init__.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the area/cli This issue/PR affects the command line interface label Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #5391 (66fd738) into master (f738d34) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5391      +/-   ##
==========================================
+ Coverage   86.84%   86.91%   +0.07%     
==========================================
  Files         101       99       -2     
  Lines        6611     6565      -46     
==========================================
- Hits         5741     5706      -35     
+ Misses        870      859      -11     
Flag Coverage Δ
jina 86.91% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rate/deployments/config/k8slib/kubernetes_tools.py 73.80% <0.00%> (-26.20%) ⬇️
...deployments/config/k8slib/kubernetes_deployment.py 47.36% <0.00%> (-10.53%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 97.05% <0.00%> (-1.97%) ⬇️
jina/orchestrate/deployments/config/helper.py 92.98% <0.00%> (-1.76%) ⬇️
jina/orchestrate/deployments/config/k8s.py 99.38% <0.00%> (-0.62%) ⬇️
jina/resources/health_check/gateway.py
jina/resources/health_check/pod.py
jina/serve/runtimes/gateway/websocket/gateway.py 100.00% <0.00%> (+1.78%) ⬆️
jina/jaml/parsers/executor/legacy.py 90.00% <0.00%> (+2.00%) ⬆️
jina/clients/request/helper.py 95.74% <0.00%> (+6.38%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@girishc13 girishc13 marked this pull request as ready for review November 14, 2022 12:50
@github-actions github-actions bot removed the area/cli This issue/PR affects the command line interface label Nov 15, 2022
@JoanFM JoanFM merged commit 11f4e2f into master Nov 15, 2022
@JoanFM JoanFM deleted the fix-serve-5386 branch November 15, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: worker runtime request handler span appears out of order
3 participants