feat: accept UUID in CUDA_VISIBLE_DEVICES round robin assignment #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
area/core
Codecov Report
@@ Coverage Diff @@
## master #5360 +/- ##
==========================================
+ Coverage 86.72% 86.83% +0.10%
==========================================
Files 99 99
Lines 6488 6494 +6
==========================================
+ Hits 5627 5639 +12
+ Misses 861 855 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alexcg1
requested changes
Nov 8, 2022
Co-authored-by: Alex Cureton-Griffiths <[email protected]>
|
📝 Docs are deployed on https://feat-RR-UUID--jina-docs.netlify.app 🎉 |
Comment on lines
+755
to
+762
| int(parts[0]) | ||
| except: | ||
| use_uuids = True | ||
|
|
||
| if not use_uuids: | ||
| return [int(p) for p in parts] | ||
| else: | ||
| return parts |
There was a problem hiding this comment.
Is it supported to have only some parts as UUID? Should we do this check for every part?
There was a problem hiding this comment.
I understand that if u pass the first as UUID, all of them will, other checks feel like overkill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
Accept UUID assignment when
ROUND-ROBINassignment ofCUDA_VISIBLE_DEVICES.