Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return the number of shards failed (if any) in the Header proto #5349

Closed
girishc13 opened this issue Nov 3, 2022 · 1 comment
Closed
Assignees
Labels

Comments

@girishc13
Copy link
Contributor

Describe the feature

#5336 adds the feature to returns incomplete response if one or more shards are failing. This will allow the search functionality to function even if one shard is unavailable. The shard unavailability can be temporary or permanent. Its up to the client to react on this information about incomplete responses.

Your proposal

The shard failure count is returned in the Head Runtime call metadata. Propagating this information to the client using the Header proto enables the client to make decisions if the partial response can be utilised or not.

Environment

Screenshots

@jina-bot
Copy link
Member

jina-bot commented Feb 2, 2023

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

@jina-bot jina-bot added the Stale label Feb 2, 2023
@JoanFM JoanFM reopened this Feb 16, 2023
@jina-bot jina-bot closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants