Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gather search results from available/on-line shards #5336

Closed
girishc13 opened this issue Oct 31, 2022 · 0 comments · Fixed by #5338
Closed

feat: gather search results from available/on-line shards #5336

girishc13 opened this issue Oct 31, 2022 · 0 comments · Fixed by #5338
Assignees
@girishc13

Comments

@girishc13
Copy link
Contributor

girishc13 commented Oct 31, 2022 •
edited
Loading

Describe the feature

Search requests should return requests from available shards rather than returning an error if one or more shards are not available.

Your proposal

The Head Runtime will manage the results from the asyncio.gather to determine the availability of shards and return incomplete result with a message to indicate the shard participation from the total shards.

Environment

Screenshots
@girishc13 girishc13 self-assigned this Oct 31, 2022
@girishc13 girishc13 changed the title Gather search results from available/on-line shards feat: gather search results from available/on-line shards Oct 31, 2022
This was referenced Nov 1, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishc13 girishc13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: capture shard failures in the head runtime jina-ai/serve
1 participant
@girishc13