Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings are stored in incorrect location due to SuperPutty.Utils.PortableSettingsProvider not being specified #806

Closed
AndrewJoncas opened this issue Jul 7, 2020 · 1 comment
Assignees
Milestone

Comments

@AndrewJoncas
Copy link

Describe the bug
The provider "SuperPutty.Utils.PortableSettingsProvider" is not specified as the provider for all settings. This causes SuperPutty settings to be saved to the users profile instead of the SuperPutty.settings. This causes external application paths such as FileZilla or WinSCP to be lost when SuperPutty is used on portable storage.

Settings Affected:
PscpHomePrefix
AutoUpdateCheck
PscpRootHomePrefix
Action_OpenScriptEditor_Shortcut
SessiontreeShowFoldersFirst
FileZillaExe
WinSCPExe
PersistCommandBarHistory
AllowPlainTextPuttyPasswordArg
PuttyDefaultParameters
SaveCommandHistoryDays
CommandBarHistory

To Reproduce
Steps to reproduce the behavior:

  1. Open SuperPutty
  2. Tools Options
  3. Enter FileZilla path
  4. Notice that the FileZilla path is stored in:
    %UserProfile%\AppData\Local\http___www.jimradford.com\SuperPutty.exe_Url_...\1.4.0.9\user.config
    instead of:
    SuperPuTTY.settings (independent of the settings being in the user profile root or application folder)

Expected behavior
user.config file should not be generated and all settings should be stored in SuperPuTTY.settings

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10

Additional context
When built with "SuperPutty.Utils.PortableSettingsProvider" specified as provider for all settings, the application works and stores settings as expected.

@AndrewJoncas AndrewJoncas changed the title Settings are stored in incorrect located due to SuperPutty.Utils.PortableSettingsProvider not being specified Settings are stored in incorrect location due to SuperPutty.Utils.PortableSettingsProvider not being specified Jul 7, 2020
jimradford added a commit that referenced this issue Nov 21, 2021
…lways uses, this ensures saved settings when used in portable mode will be stored in the correct file/location. Fixes issue #806
@jimradford
Copy link
Owner

Thanks for the report, the fix has been comitted.

@jimradford jimradford self-assigned this Nov 21, 2021
@jimradford jimradford added this to the v1.4.10 milestone Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants