Partially closes #13 on Firefox in order to prepare to Chrome future release #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Firefox Cleanup unused reference
|
This also resolved a rather new issues I was facing with Chrome 98 and StreamSaver.js. Thank you for sharing the patch. |
|
@jimmywarting Can we get a merge on it? 🥺 |
|
yea, sure. it's a quick and easy fix also this needs to be backwards compatible also cuz it depends on a public service worker that everyone depends on. |
yume-chan
pushed a commit
to yume-chan/StreamSaver.js
that referenced
this pull request
Feb 18, 2022
…n Firefox (jimmywarting#261) Cleanup unused reference
1 task
1 task
jimmywarting
added a commit
that referenced
this pull request
Mar 6, 2023
* fix #172 firefox download only working once in HTTP (#173) * - type checking (closes #181) - better typing (jsdoc) * fixed typos in readme (#196) Just a few small grammatical fixes * Clarify what ‘it’ references, fix typo/brain fart (#207) * Fixed :) (#214) * Fix minor spelling errors (#199) * Fix typos * fix minor spelling errors * added funding * Update FUNDING.yml * Update README.md * Update README.md * Typo * add licence * Replicated chrome (canary: 99.0.4828.0) user cancellation behaviour on Firefox (#261) Cleanup unused reference * update link to whatwg/fs * bump minor * fix: support large streams in Firefox (#305) * add note to self about FF v102 --------- Co-authored-by: Nomeji <[email protected]> Co-authored-by: Jimmy Wärting <[email protected]> Co-authored-by: Kyle J. Davis <[email protected]> Co-authored-by: Hein Haraldson Berg <[email protected]> Co-authored-by: Bonjour Comosava <[email protected]> Co-authored-by: Christopher Chamberlain <[email protected]> Co-authored-by: tania daniela paiva <[email protected]> Co-authored-by: Gabriel Pacheco <[email protected]> Co-authored-by: Jeremy Kahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #13 was reported, Chrome had an issue where
StreamSaver.js/sw.js
Line 66 in cd8e32a
Also, reported on #13, ticket was filled in for the chrome team (ticket #638494) a few years ago and it got merged last week.
Testing on Canary version
99.0.4828.0, cancellation event still not being triggered but worker seems to be killed on user cancellation causing stream saver to write to throw atwrite(). (more investigation on this behaviour is actually needed but it does not allow more writing on the main thread as expected).Now, to make sure we do abort the operation at user cancellation on Firefox, that does not kill the worker but just closes the file descriptor and maintains the worker running without sending any signal to the main thread the proposed changes are implemented.