ArrayedObjectInstantiator and ArrayedObjectFactory singleton

jimmyoak · Jun 17, 2015 · 958dbb2 · 958dbb2
1 parent 7507307
commit 958dbb2
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 2 deletions.
diff --git a/src/DataType/ArrayedObjectFactory.php b/src/DataType/ArrayedObjectFactory.php
@@ -4,6 +4,21 @@
 
 class ArrayedObjectFactory
 {
+    private function __construct()
+    {
+    }
+
+    public static function instance()
+    {
+        static $instance;
+
+        if (null === $instance) {
+            $instance = new static();
+        }
+
+        return $instance;
+    }
+
     public function create($object)
     {
         return new ArrayedObject(get_class($object), $this->arrayzeObjectVars($object));

diff --git a/src/DataType/ArrayedObjectInstantiator.php b/src/DataType/ArrayedObjectInstantiator.php
@@ -14,6 +14,21 @@ class ArrayedObjectInstantiator
         \DateInterval::class => 'createDateIntervalInstance',
     ];
 
+    private function __construct()
+    {
+    }
+
+    public static function instance()
+    {
+        static $instance;
+
+        if (null === $instance) {
+            $instance = new static();
+        }
+
+        return $instance;
+    }
+
     /**
      * @param ArrayedObject $arrayedObject
      *

diff --git a/test/DataType/ArrayedObjectFactoryTest.php b/test/DataType/ArrayedObjectFactoryTest.php
@@ -15,7 +15,16 @@ class ArrayedObjectFactoryTest extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        $this->factory = new ArrayedObjectFactory();
+        $this->factory = ArrayedObjectFactory::instance();
+    }
+
+
+    /** @test */
+    public function shouldBeSingleton()
+    {
+        $isConstructorCallable = is_callable([$this->factory, '__construct']);
+
+        $this->assertFalse($isConstructorCallable);
     }
 
     /** @test */

diff --git a/test/DataType/ArrayedObjectInstantiatorTest.php b/test/DataType/ArrayedObjectInstantiatorTest.php
@@ -14,7 +14,15 @@ class ArrayedObjectInstantiatorTest extends \PHPUnit_Framework_TestCase
 
     protected function setUp()
     {
-        $this->instantiator = new ArrayedObjectInstantiator();
+        $this->instantiator = ArrayedObjectInstantiator::instance();
+    }
+
+    /** @test */
+    public function shouldBeSingleton()
+    {
+        $isConstructorCallable = is_callable([$this->instantiator, '__construct']);
+
+        $this->assertFalse($isConstructorCallable);
     }
 
     /** @test */