Explicitly clear PoolManager by using context manager

Fixes SeleniumHQ#6878 This is meant to solve ResourceWarning messages when WebDrivers are instanced with a KeepAlive=False.
jimevans · Sep 8, 2019 · 88ecc54 · 88ecc54
1 parent 2d7ee92
commit 88ecc54
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/py/selenium/webdriver/remote/remote_connection.py b/py/selenium/webdriver/remote/remote_connection.py
@@ -371,8 +371,8 @@ def _request(self, method, url, body=None):
 
             statuscode = resp.status
         else:
-            http = urllib3.PoolManager(timeout=self._timeout)
-            resp = http.request(method, url, body=body, headers=headers)
+            with urllib3.PoolManager(timeout=self._timeout) as http:
+                resp = http.request(method, url, body=body, headers=headers)
 
             statuscode = resp.status
             if not hasattr(resp, 'getheader'):