Improve source code #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arielsvn Looks good! ✨ Could you please add yourself as contributor in |
…the library can access this method
|
done @IonicaBizau I also made the helper |
|
Thanks a lot! 🎉 Landed in 1.1.0. 🚢 🚀 |
|
Thank you too!!! It was my pleasure 🎱 |
|
@arielsvn BTW, this was your first merged PR on GitHub, right? 😄 👍 |
|
Yes it is, really cool!!! Ionică Bizău [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I putted all the code inside a global function call, and after that the method
insertHtmlAtCaretcan be used as a helper. Before it was a helper of theCustomHtmlobject, this isn't good because the function will be recreated every timeCustomHtmlis instantiated.The diff looks strange because the indentation changed.