Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Lambda handlers to include cookies in the response #620

Merged
merged 3 commits into from
Apr 28, 2024
Merged

Conversation

jill64
Copy link
Owner

@jill64 jill64 commented Apr 28, 2024

related #604

Summary by CodeRabbit

  • New Features

    • Enhanced response handling across multiple server architectures to include cookies, improving session management and personalization capabilities.
  • Documentation

    • Updated package version and repository details to keep users informed about the latest version and project resources.

@wraith-ci
Copy link
Contributor

wraith-ci bot commented Apr 28, 2024

Wraith CI 👻 Retry Request

Check the box to re-trigger CI.

  • Wraith CI
  • Wraith CI / PR

Copy link

coderabbitai bot commented Apr 28, 2024

Walkthrough

The recent updates across multiple TypeScript files involve enhancing the response data by extracting cookies from headers and including them in the returned objects. This improvement ensures that cookies are now part of the data package returned to the client, alongside the existing response components like status code, headers, and body.

Changes

File Path Change Summary
.../edge-unbundled/server-buffered.ts Extracted cookies from response headers and added them to the return object.
.../lambda-mono-buffered.ts Added cookie extraction in the handler function, included in the return object.
.../lambda-s3-buffered.ts Extracted cookies from response headers and included them in the return payload.

🐰✨🍪
A little rabbit hopped along,
Spreading joy with a code song.
"Now cookies we can clearly see,
In headers where they ought to be!
Gather 'round, let's cheer, hooray!
For data's shared the proper way."
🌟🐾


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wraith-ci wraith-ci bot enabled auto-merge April 28, 2024 12:34
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Comment on lines +38 to +39
const cookies = response.headers.get('set-cookie')?.split(',')

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider improving the cookie parsing logic.

The current implementation splits cookies by commas, which might not correctly handle cookies that contain commas within their values. Consider using a more robust parsing method that correctly handles such cases.

Comment on lines +49 to +50
const cookies = response.headers.get('set-cookie')?.split(',')

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider improving the cookie parsing logic.

As in the previous file, the method used to split cookies might not handle cookies with commas in their values correctly. A more robust parsing method is recommended.

Comment on lines +54 to +55
const cookies = response.headers.get('set-cookie')?.split(',')

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider improving the cookie parsing logic.

As in the other files, the method used to split cookies might not handle cookies with commas in their values correctly. A more robust parsing method is recommended.

@wraith-ci wraith-ci bot merged commit 45ca34b into main Apr 28, 2024
18 checks passed
@wraith-ci wraith-ci bot deleted the dev branch April 28, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant