Make log more friendly for TiDB Cloud es log service #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang [email protected]
What problem does this PR solve?
Issue Number: close pingcap#5134
Problem Summary:
Now we use
__global__.log_dump_4as logging identifier, which is not friendly for TiDB Cloud log service. We can not get the logs by filtering__global__.log.https://github.com/pingcap/tiflash/blob/10bcb06bcd379601014c70b6dd9173bb960b3c32/dbms/src/Storages/Page/V3/PageDirectory.cpp#L1226-L1234
Change the identifier format to be
__global__.log.dump_4is more friendly for log searchingWhat is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note