Clone attributes in shallowClone()

jhy · May 12, 2019 · eaf876d · eaf876d
1 parent 82e2c44
commit eaf876d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/main/java/org/jsoup/nodes/Element.java b/src/main/java/org/jsoup/nodes/Element.java
@@ -1468,7 +1468,7 @@ public Element clone() {
     @Override
     public Element shallowClone() {
         // simpler than implementing a clone version with no child copy
-        return new Element(tag, baseUri, attributes);
+        return new Element(tag, baseUri, attributes == null ? null : attributes.clone());
     }
 
     @Override

diff --git a/src/test/java/org/jsoup/nodes/ElementTest.java b/src/test/java/org/jsoup/nodes/ElementTest.java
@@ -668,10 +668,13 @@ public class ElementTest {
 
         assertEquals(1, p.childNodeSize());
         assertEquals(0, p2.childNodeSize());
+
         assertEquals("", p2.text());
+        assertEquals("One", t2.text());
 
         assertEquals("two", p2.className());
-        assertEquals("One", t2.text());
+        p2.removeClass("two");
+        assertEquals("two", p.className());
 
         d2.append("<p id=3>Three");
         assertEquals(1, d2.childNodeSize());