improvements to protoparse's handling of message literals #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a custom option's type is a message and the value is defined using a message literal,
protoc
parses the content of the message literal as the protobuf text format.The protobuf text format has some quirks that were not previously handled by protoparse:
Also, protoparse was not previously handling the case where an enum is defined with enum values whose names conflict with certain keywords ("true", "false", "inf", "nan"). The parser would see these identifiers and eagerly convert to bool or float values and then complain about their use with the enum. Instead, parsing should always represent these identifiers using identifier nodes in the AST (not bool or float literal nodes), and they can then be converted to bools/floats as needed. That way, if they need to instead be interpreted as enum value names, they can be.