Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functionalize url-check #155

Closed
wants to merge 5 commits into from
Closed

Functionalize url-check #155

wants to merge 5 commits into from

Conversation

howardbaik
Copy link
Contributor

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Functionalizes url-check.R

What GitHub issue does your pull request address?

#152

@howardbaik howardbaik changed the title Url check Functionalize url-check Jul 10, 2024
cansavvy
cansavvy reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you tell me more about how you've tested this so far?
  2. Can you also add some documentation for these arguments and examples for their usage?

Thanks for getting this going @howardbaek !!!

@cansavvy cansavvy closed this Aug 2, 2024
@cansavvy cansavvy deleted the url_check branch August 2, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cansavvy cansavvy cansavvy left review comments

@kweav kweav Awaiting requested review from kweav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howardbaik @cansavvy