-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Mongodb Driver #1
base: master
Are you sure you want to change the base?
Conversation
meabed
commented
Dec 27, 2017
- Adding Mongodb Driver
- Update Readme to include Mongodb
- Update Readme to include Mongodb
Awesome project Thank you. |
Thank you for this! I have never used MongoDB before, so I will have to learn a bit about it and install a local version, so I can test this. If I merge this PR, I have to be able to support it going forward, and for that I have to understand how Mongo works. I'm a bit concerned about converting all binary records to base64 -- is this really the only way to do it with Mongo? That seems extremely wasteful. I have applications that store 100MB binary records, for example. Why are we creating an index on every startup? Isn't this incorrect? I am referring to this line: self.collection.createIndex({key: 1}, function (err, result) { Maybe I just don't understand MongoDB, but it seems like the index should only need to be created on the collection one time only, when the collection is first created. Small typo in your docs addition for
This logic is reversed. When I might want to change the name of the module from Thanks again! |
Thanks @jhuckaby for the review :) No worries get sometime to use mongodb =)
Thanks 👍 let me know if you got chance to test it :) The reason this driver is helpful is MongoDB is very popular and its 1 minute to get it up and running in docker container! I have tried the Couchbase configuration but it took me ages to get it up :) and yet couldn't figure out many things :) must be me because i'm know to it, but nevertheless the more drivers the better :) |
ping :) |
@jhuckaby have you had a chance to look the PR :) anything needed i can do to help getting it tested and merged? Thanks |
Hello. I am very sorry, but I have not had time to test this, and am not ready to merge the PR yet. I have never used MongoDB in my entire life, so I am completely ignorant to it. If I am to merge this PR in with the base code, I have to understand how to install it, and use it, and test it. This will take some time. I apologize, but I will get to this as soon as I can. Thank you again for the great PR! |
no worries :) let me know if i could be in any help! |