Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert the user if they try to use the extension in a chrome:// url #9

Closed
jhubert opened this issue Dec 2, 2014 · 0 comments · Fixed by #10
Closed

Alert the user if they try to use the extension in a chrome:// url #9

jhubert opened this issue Dec 2, 2014 · 0 comments · Fixed by #10

Comments

@jhubert
Copy link
Owner

jhubert commented Dec 2, 2014

It just doesn't work. Tell the user that.
jhubert added a commit that referenced this issue Dec 2, 2014
@jhubert
Use Chrome commands instead of custom key commands
7577109 
- Alert the user if they use it on a chrome:// url. Closes #9
- Alert the user if they use it on a file:/// url. Closes #7
- Set the default chrome key command to Shift+Ctrl+E. Closes #8
- General code cleanup and linting
jhubert added a commit that referenced this issue Dec 2, 2014
@jhubert
Use Chrome commands instead of custom key commands
0f2f903 
- Alert the user if they use it on a chrome:// url. Closes #9
- Alert the user if they use it on a file:/// url. Closes #7
- Set the default chrome key command to Shift+Ctrl+E. Closes #8
- General code cleanup and linting

This commit also makes the box size save properly if the user uses
the key command to close the editor because of the way that the
browser_action commands work. Per #1
@jhubert jhubert mentioned this issue Dec 2, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Chrome commands instead of custom key commands jhubert/live-css-editor
1 participant
@jhubert