fix wrong resolving of responses component using $ref

Signed-off-by: Jihyeon Gim <[email protected]>
jhthorsen · Oct 12, 2024 · 03d222c · 03d222c
1 parent 6677979
commit 03d222c
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/lib/JSON/Validator/Schema/OpenAPIv3.pm b/lib/JSON/Validator/Schema/OpenAPIv3.pm
@@ -91,8 +91,7 @@ sub parameters_for_response {
   my $cache_key = "parameters_for_response:$method:$path:$status";
   return $self->{cache}{$cache_key} if $self->{cache}{$cache_key};
 
-  my $responses = $self->get([paths => $path, $method, 'responses']);
-  my $response  = $responses->{$status} || $responses->{default};
+  my $response = $self->get([paths => $path, $method, 'responses', $status]) || $self->get([paths => $path, $method, 'responses', 'default']);
   return undef unless $response;
 
   my @parameters;

diff --git a/t/openapiv3-basic.t b/t/openapiv3-basic.t
@@ -127,6 +127,15 @@ subtest 'validate_response - accept' => sub {
     'negotiated content type';
 };
 
+subtest 'validate_response - resusable response' => sub {
+  $body   = {accept => 'application/*'};
+  @errors = $schema->validate_response([get => '/pets', 201], {body => \&body});
+  is "@errors", '', 'valid accept';
+  is_deeply $body,
+    {accept => 'application/*', content_type => 'application/json', in => 'body', name => 'body', valid => 1},
+    'negotiated content type';
+};
+
 subtest 'validate_response - content_type' => sub {
   $body   = {content_type => 'text/plain'};
   @errors = $schema->validate_response([get => '/pets'], {body => \&body});

diff --git a/t/spec/v3-petstore.json b/t/spec/v3-petstore.json
@@ -57,6 +57,9 @@
               "application/xml": { "schema": { "$ref": "#/components/schemas/Pets" } }
             }
           },
+          "201": {
+            "$ref": "#/components/responses/Pets"
+          },
           "default": {
             "description": "unexpected error",
             "content": {
@@ -119,6 +122,15 @@
           "message": { "type": "string" }
         }
       }
+    },
+    "responses": {
+        "Pets": {
+            "description": "Reusable Pets response",
+            "content": {
+              "application/json": { "schema": { "$ref": "#/components/schemas/Pets" } },
+              "application/xml": { "schema": { "$ref": "#/components/schemas/Pets" } }
+            }
+        }
     }
   }
 }