Merge pull request #70 from icann-dns/sensetive_password

ipmi::user: Mask passwords
jhoblitt · Jan 16, 2024 · 8f73daf · 8f73daf
2 parents ac909d2 + db1774f
commit 8f73daf
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/manifests/user.pp b/manifests/user.pp
@@ -67,9 +67,10 @@
     }
 
     exec { "ipmi_user_setpw_${title}":
-      command => "/usr/bin/ipmitool user set password ${user_id} \'${real_password}\'",
-      unless  => "/usr/bin/ipmitool user test ${user_id} 16 \'${real_password}\'",
-      notify  => [Exec["ipmi_user_enable_${title}"], Exec["ipmi_user_enable_sol_${title}"], Exec["ipmi_user_channel_setaccess_${title}"]],
+      environment => ["PASSWORD=${real_password}"],
+      command     => "/usr/bin/ipmitool user set password ${user_id} \'\$PASSWORD\'",
+      unless      => "/usr/bin/ipmitool user test ${user_id} 16 \'\$PASSWORD\'",
+      notify      => [Exec["ipmi_user_enable_${title}"], Exec["ipmi_user_enable_sol_${title}"], Exec["ipmi_user_channel_setaccess_${title}"]],
     }
 
     exec { "ipmi_user_enable_sol_${title}":