-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload binary artifacts on github release #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it good to go or does it need some further work ?
It should be good to go, but I only tested the linux artifact. |
Thanks @Shaolans ! If you find a way to reduce the binary size, it would be wonderful ! I just need to create the changelog and will do the release |
Yes, it is quite a bummer that this weight 100mb+ I was quite surprised |
I'm guessing that's mainly coming from Node.js being bundled? And I would imagine there's at least 3 versions included (Linux/OSX/Windows) I bundled prettier-java into a single JS file using webpack which only came out ~3MB if I remember correctly, but this requires the user to bring their own Node.js |
I think the Node.js bundle is about ~40MB. |
@Shaolans The hook is failing on Mac Os :/ Can we add this only in ci ? Got this: |
@clementdessoude I think gnu-sed is mandatory, have you this installed ? |
What changed with this PR:
This PR will provide binary artifacts on github release.
Working on linux but I have tested for macos or windows thought.
Close #326
Example
Relative issues or prs: