Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload binary artifacts on github release #399

Merged
merged 3 commits into from
May 6, 2020

Conversation

Shaolans
Copy link
Member

@Shaolans Shaolans commented May 4, 2020

What changed with this PR:

This PR will provide binary artifacts on github release.
Working on linux but I have tested for macos or windows thought.

Close #326

Example

// Input

// Output

Relative issues or prs:

Copy link
Contributor

@clementdessoude clementdessoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it good to go or does it need some further work ?

@clementdessoude clementdessoude self-requested a review May 5, 2020 22:23
@Shaolans
Copy link
Member Author

Shaolans commented May 6, 2020

Is it good to go or does it need some further work ?

It should be good to go, but I only tested the linux artifact.

@clementdessoude clementdessoude merged commit 646ac86 into jhipster:master May 6, 2020
@clementdessoude
Copy link
Contributor

Thanks @Shaolans ! If you find a way to reduce the binary size, it would be wonderful ! I just need to create the changelog and will do the release

@Shaolans
Copy link
Member Author

Shaolans commented May 6, 2020

Yes, it is quite a bummer that this weight 100mb+ I was quite surprised

@jhaber
Copy link
Contributor

jhaber commented May 6, 2020

I'm guessing that's mainly coming from Node.js being bundled? And I would imagine there's at least 3 versions included (Linux/OSX/Windows)

I bundled prettier-java into a single JS file using webpack which only came out ~3MB if I remember correctly, but this requires the user to bring their own Node.js

@Shaolans
Copy link
Member Author

Shaolans commented May 7, 2020

I think the Node.js bundle is about ~40MB.
I found a way to compress the binary with gzexe for the linux binary but at a great cost. It quadruple the runtime time on my machine...

@clementdessoude
Copy link
Contributor

clementdessoude commented May 10, 2020

@Shaolans The hook is failing on Mac Os :/ Can we add this only in ci ?

Got this: sed: illegal option -- r

@clementdessoude clementdessoude mentioned this pull request May 10, 2020
@Shaolans
Copy link
Member Author

Shaolans commented May 10, 2020

@clementdessoude I think gnu-sed is mandatory, have you this installed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a standalone binary artifact
3 participants