This repository has been archived by the owner on Mar 21, 2021. It is now read-only.
#7423 Open uploaded files in IE11 and Edge #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarziou
reviewed
Apr 7, 2018
src/service/data-util.service.ts
Outdated
| win.document.write( | ||
| '<iframe src="' + fileURL + '" frameborder="0" style="border:0; top:0px; left:0px; bottom:0px; right:0px; width:100%; height:100%;" allowfullscreen></iframe>'); | ||
| if (window.navigator && window.navigator.msSaveOrOpenBlob) { | ||
| const byteCharacters = atob(data); |
There was a problem hiding this comment.
Maybe add one line comment to say it's for IE and Edge
|
@deepu105 you might want to do the same in react-jhipster: https://github.com/jhipster/react-jhipster/blob/master/src/util/data-utils.ts#L15-L23 |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to open files uploaded in MS Internet Explored 11and MS Edge.
Reported at jhipster/generator-jhipster#7423