-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tailwindcss to thymeleaf template module #8358
add tailwindcss to thymeleaf template module #8358
Conversation
I've created the tests and decided to open this draft pull request before moving forward with the implementation. This is to keep everyone informed about my current work. Please feel free to provide any comments or suggestions. I will add the tailwindcss from the list:
|
Great @renanfranca, together with #8327 I guess we are done with a first feature complete version. |
Thanks, @atomfrede, for taking a look! That's great news! |
d7419aa
to
8ff6012
Compare
Hi @atomfrede ! I attempted to use the live reload feature as described in the README.md, but unfortunately, it didn't work. I also ran the project from https://github.com/wimdeblauwe/ttcli, and encountered the same issue with live reload not functioning. I've nearly completed all the necessary steps, but now I'm looking to modify the index file to incorporate TailwindCSS classes following the application of the TailwindCSS module. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8358 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 2705 2709 +4
===========================================
Files 708 708
Lines 11960 12031 +71
Branches 249 249
===========================================
+ Hits 11960 12031 +71 ☔ View full report in Codecov by Sentry. |
Need to check how its done. Wims approach is a little different from what I usually use with gradle and spring devtool and the live reload server. What issues did you encounter? |
I change the index.html file and it didn't live reload. I had to stop and rerun the spring boot application to see the change. edit: maybe i didn't enable springboot dev tools |
8ff6012
to
4796c10
Compare
@atomfrede : I forgot to add the spring-boot-devtools module, It works really well after adding this module 😄. I update the Thymeleaf readme file with this information. It is almost done, I am going to improve the index.html with tailwindcss 👍 |
4796c10
to
a9e1299
Compare
Hi @atomfrede ! The pull request is now ready for review 😄 This issue was more challenging than I anticipated. I had to work with package.json, replace existing code from a previous module, and use the generated project with live reload to implement the welcome screen using Tailwind CSS. I utilized a variety of Tailwind CSS classes and images to provide an opportunity for those unfamiliar with Tailwind CSS to learn. Finally, I retained only the necessary code, adding fixes and complementary code for the Tailwind CSS setup from the project at https://github.com/wimdeblauwe/ttcli/releases, which served as my basis. |
Awesome @renanfranca will have look later today. I would say let's get #8327 merged first, I guess there will be some conflicts afterwards. |
Thanks @atomfrede ! I agree! I will rebase and solve the conflicts after merging the other pull request 👍 |
@renanfranca Can you rebase? |
I will do it when my daughter sleeps 😅 |
a9e1299
to
5d2f624
Compare
@atomfrede It is done 😉 ! I wish you happy holidays and a Happy New Year! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
...enerator/server/springboot/thymeleaf/template/domain/ThymeleafTemplateModuleFactoryTest.java
Outdated
Show resolved
Hide resolved
...te/generator/server/springboot/thymeleaf/template/domain/ThymeleafTemplateModuleFactory.java
Outdated
Show resolved
Hide resolved
5d2f624
to
d2cea18
Compare
@murdos: Thank you! I pushed a new version! |
d2cea18
to
6a3036c
Compare
Thank you, @DanielFran! I've pushed a new version. Could that be the reason why the bot didn't update those dependency versions?" |
Probably |
@renanfranca Can you fix the conflicts? |
6a3036c
to
05a9412
Compare
@atomfrede : Cool! I pushed the new version 👍 |
@DanielFran: is that ok for you now? Since you requested changes, I can't merge the PR. |
See #4339