Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tailwindcss to thymeleaf template module #8358

Conversation

renanfranca
Copy link
Contributor

See #4339

@renanfranca
Copy link
Contributor Author

I've created the tests and decided to open this draft pull request before moving forward with the implementation. This is to keep everyone informed about my current work. Please feel free to provide any comments or suggestions.

I will add the tailwindcss from the list:

  • thymeleaf
  • webjars
  • htmx
  • alpine
  • tailwind
  • (or bootstrap)
  • skeleton layout and index files

@atomfrede
Copy link
Member

Great @renanfranca, together with #8327 I guess we are done with a first feature complete version.

@renanfranca
Copy link
Contributor Author

Great @renanfranca, together with #8327 I guess we are done with a first feature complete version.

Thanks, @atomfrede, for taking a look! That's great news!

@renanfranca renanfranca force-pushed the 4339-add-tailwindcss-to-thymeleaf-template branch from d7419aa to 8ff6012 Compare December 13, 2023 19:58
@renanfranca
Copy link
Contributor Author

Hi @atomfrede !

I attempted to use the live reload feature as described in the README.md, but unfortunately, it didn't work. I also ran the project from https://github.com/wimdeblauwe/ttcli, and encountered the same issue with live reload not functioning.

I've nearly completed all the necessary steps, but now I'm looking to modify the index file to incorporate TailwindCSS classes following the application of the TailwindCSS module.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a9a43a) 100.00% compared to head (05a9412) 100.00%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #8358   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2705      2709    +4     
===========================================
  Files            708       708           
  Lines          11960     12031   +71     
  Branches         249       249           
===========================================
+ Hits           11960     12031   +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atomfrede
Copy link
Member

Need to check how its done. Wims approach is a little different from what I usually use with gradle and spring devtool and the live reload server. What issues did you encounter?

@renanfranca
Copy link
Contributor Author

renanfranca commented Dec 13, 2023

Need to check how its done. Wims approach is a little different from what I usually use with gradle and spring devtool and the live reload server. What issues did you encounter?

I change the index.html file and it didn't live reload. I had to stop and rerun the spring boot application to see the change.

edit: maybe i didn't enable springboot dev tools

@renanfranca renanfranca force-pushed the 4339-add-tailwindcss-to-thymeleaf-template branch from 8ff6012 to 4796c10 Compare December 14, 2023 03:18
@renanfranca
Copy link
Contributor Author

Need to check how its done. Wims approach is a little different from what I usually use with gradle and spring devtool and the live reload server. What issues did you encounter?

@atomfrede : I forgot to add the spring-boot-devtools module, It works really well after adding this module 😄. I update the Thymeleaf readme file with this information.

It is almost done, I am going to improve the index.html with tailwindcss 👍

@renanfranca renanfranca force-pushed the 4339-add-tailwindcss-to-thymeleaf-template branch from 4796c10 to a9e1299 Compare December 18, 2023 14:58
@renanfranca renanfranca marked this pull request as ready for review December 18, 2023 15:00
@renanfranca
Copy link
Contributor Author

Hi @atomfrede !

The pull request is now ready for review 😄

This issue was more challenging than I anticipated. I had to work with package.json, replace existing code from a previous module, and use the generated project with live reload to implement the welcome screen using Tailwind CSS. I utilized a variety of Tailwind CSS classes and images to provide an opportunity for those unfamiliar with Tailwind CSS to learn. Finally, I retained only the necessary code, adding fixes and complementary code for the Tailwind CSS setup from the project at https://github.com/wimdeblauwe/ttcli/releases, which served as my basis.

@atomfrede
Copy link
Member

Awesome @renanfranca will have look later today. I would say let's get #8327 merged first, I guess there will be some conflicts afterwards.

@renanfranca
Copy link
Contributor Author

Thanks @atomfrede ! I agree! I will rebase and solve the conflicts after merging the other pull request 👍

@atomfrede
Copy link
Member

@renanfranca Can you rebase?

@renanfranca
Copy link
Contributor Author

@renanfranca Can you rebase?

I will do it when my daughter sleeps 😅

@renanfranca renanfranca force-pushed the 4339-add-tailwindcss-to-thymeleaf-template branch from a9e1299 to 5d2f624 Compare December 31, 2023 03:27
@renanfranca
Copy link
Contributor Author

@atomfrede It is done 😉 !

I wish you happy holidays and a Happy New Year! 🥳

Copy link
Member

@atomfrede atomfrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@renanfranca renanfranca force-pushed the 4339-add-tailwindcss-to-thymeleaf-template branch from 5d2f624 to d2cea18 Compare January 2, 2024 15:50
@renanfranca renanfranca requested a review from murdos January 2, 2024 15:55
@renanfranca
Copy link
Contributor Author

@murdos: Thank you! I pushed a new version!

@renanfranca renanfranca force-pushed the 4339-add-tailwindcss-to-thymeleaf-template branch from d2cea18 to 6a3036c Compare January 2, 2024 16:09
@renanfranca
Copy link
Contributor Author

Thank you, @DanielFran! I've pushed a new version. Could that be the reason why the bot didn't update those dependency versions?"

@renanfranca renanfranca requested a review from DanielFran January 2, 2024 16:12
@DanielFran
Copy link
Member

Thank you, @DanielFran! I've pushed a new version. Could that be the reason why the bot didn't update those dependency versions?"

Probably

murdos
murdos previously approved these changes Jan 2, 2024
@atomfrede
Copy link
Member

@renanfranca Can you fix the conflicts?

@renanfranca renanfranca force-pushed the 4339-add-tailwindcss-to-thymeleaf-template branch from 6a3036c to 05a9412 Compare January 8, 2024 21:16
@renanfranca
Copy link
Contributor Author

@renanfranca Can you fix the conflicts?

@atomfrede : Cool! I pushed the new version 👍

@murdos
Copy link
Contributor

murdos commented Jan 8, 2024

@DanielFran: is that ok for you now? Since you requested changes, I can't merge the PR.

@DanielFran DanielFran merged commit 35e53fb into jhipster:main Jan 8, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants