-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tikui, vue & cypress headless failling #11653
Conversation
89f4287
to
2167cbc
Compare
So sad I haven't though about that solution... Sounds good, haven't tested it for now |
🙂 |
@@ -35,7 +35,7 @@ public JHipsterModule buildComponentTestsModule(JHipsterModuleProperties propert | |||
.addScript(scriptKey("test:component"), scriptCommand("start-server-and-test start http://localhost:9000 'cypress open --e2e --config-file src/test/webapp/component/cypress-config.ts'")) | |||
.addScript( | |||
scriptKey("test:component:headless"), | |||
scriptCommand("start-server-and-test start http://localhost:9000 'cypress run --headless --config-file src/test/webapp/component/cypress-config.ts'") | |||
scriptCommand("start-server-and-test dev http://localhost:9000 'cypress run --headless --config-file src/test/webapp/component/cypress-config.ts'") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I made similar changes to generator, I had to use serve
because tikui-core serve
was not behaving correctly (it was lazy loading resources if I remember correctly, so the first real http request was in failure): 4be8819
It seems that things have change, and that it now works as expected.
We should also note that npm run dev
starts things in parallel, so in theory, just verifying http://localhost:9000 is not sufficient. In practice it seems to work, and we don't have a better solution, so I guess it's fine as is.
@@ -35,7 +35,7 @@ public JHipsterModule buildComponentTestsModule(JHipsterModuleProperties propert | |||
.addScript(scriptKey("test:component"), scriptCommand("start-server-and-test start http://localhost:9000 'cypress open --e2e --config-file src/test/webapp/component/cypress-config.ts'")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also change test:component
script, they are similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I update
2167cbc
to
adde907
Compare
Fix #11642