Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spring Boot LangChain4j sample #11335

Merged
merged 16 commits into from
Nov 11, 2024

Conversation

anunnakian
Copy link
Member

@anunnakian anunnakian commented Nov 10, 2024

Add a sample of using LangChain4J with Spring Boot Web

@anunnakian
Copy link
Member Author

@pascalgrimaud here is the PR to add a LangChain4j sample ;)

@pascalgrimaud
Copy link
Member

In the last PR, I forgot to tell you to add a new config to test in the CI, the new modules langchain4j

Could you add a new one here?

Then, add it to the CI:

@pascalgrimaud
Copy link
Member

By adding to the CI the generated app, it will show you that the generated app with langchain4j is not totally covered: missing tests for ChatResource

@@ -111,6 +111,8 @@ cucumber_with_jwt() {
"spring-boot-cucumber-jwt-authentication"
}

echo $application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo $application

@pascalgrimaud
Copy link
Member

Cc @renanfranca : what happened when we added a new config in script.sh and it doesn't exist in main branch? The checksum with md5 should be ignored, right?

@renanfranca
Copy link
Contributor

Cc @renanfranca : what happened when we added a new config in script.sh and it doesn't exist in main branch? The checksum with md5 should be ignored, right?

The pipeline will break because the MD5 checksum is generated after it tries and fails to create the non-existent app in generate.sh in the main branch.

In my previous experience creating a new app in generate.sh and adding it to the github-actions.yml matrix, I had to add the new app in generate.sh and merge it with the main branch. Only after that could I add the new app to the matrix.

I saw your comment here only today. Yes, i think it should ignored non existing apps.

@renanfranca
Copy link
Contributor

I saw your comment here only today. Yes, i think it should ignored non existing apps.

But will it run on main branch CI? I think so...

@renanfranca
Copy link
Contributor

I saw your comment here only today. Yes, i think it should ignored non existing apps.

But will it run on main branch CI? I think so...

Screenshot_20241110_231019_Vivaldi

I am having second thoughts about the importance of checking out the complete project from the main branch if it's only using the test-ci folder to run commands with the downloaded main jar file, which is not updated and generates an error when adding a new app in generate.sh and including the app in the GitHub Actions matrix in a pull request.

@pascalgrimaud and @murdos : What do you think about checking out from the current branch as well at step name: 'Setup: checkout project from main branch' and keeping everything else unchanged?

@pascalgrimaud
Copy link
Member

I created the ticket here #11341

@pascalgrimaud pascalgrimaud marked this pull request as ready for review November 11, 2024 09:40
@pascalgrimaud pascalgrimaud merged commit 28abff4 into jhipster:main Nov 11, 2024
9 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants