Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: migrate Eslint configuration to recommended flat config #10858

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

qmonmert
Copy link
Contributor

No description provided.

Copy link
Contributor

@murdos murdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was precisely trying to migrate eslint configuration to flat config, while investigating why there was linting issue on CI in #10849

@murdos murdos enabled auto-merge September 15, 2024 20:44
@murdos murdos changed the title Bug Angular: commit in generated app is in error Angular: migrate Eslint configuration to recommended flat config Sep 15, 2024
@murdos murdos added area: enhancement 🔧 and removed area: bug 🐛 Something isn't working labels Sep 15, 2024
@murdos
Copy link
Contributor

murdos commented Sep 15, 2024

@qmonmert : I changed the title of the PR to better reflect its content.
I think the original issue you had while committing was caused by the absence of prettier in the generated angularapp.

@qmonmert
Copy link
Contributor Author

@murdos 🤝

@murdos murdos merged commit b8f1890 into jhipster:main Sep 15, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants