Remove AngularCookieLocaleResolver #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose those checks should start passing after jhipster/generator-jhipster#23818 gets merged? |
|
@shrralis Yes |
shrralis
force-pushed
the
fix-20106-drop-AngularCookieLocaleResolver
branch
from
22786f4 to
a069f04
Compare
remove AngularCookieLocaleResolver due to be a leftover from angularjs Fix #20106
|
Thanks @shrralis for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove AngularCookieLocaleResolver due to being a leftover from angularjs, a companion of jhipster/generator-jhipster#23818
Fix jhipster/generator-jhipster#20106