Remove JMX to improve start-up performance #8974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +59,7 @@ import java.util.Collection; | |||
| excludeFilters = @ComponentScan.Filter(type = FilterType.ASSIGNABLE_TYPE, classes = OAuth2InterceptedFeignConfiguration.class) | |||
| ) | |||
| <%_ } _%> | |||
| @SpringBootApplication | |||
| @SpringBootApplication(exclude = JmxAutoConfiguration.class) | |||
There was a problem hiding this comment.
Are you sure this needs to be excluded ? some people might want to activate it later.
There was a problem hiding this comment.
Yes I'll revert this: I'm just following the blog post here, I'm not finding any great improvements by removing JMX. Then, I see it also as a security risk, so let's remove it be default.
(I can't write here what I've done with JMX in the past, but trust me there were several very high security issues because JMX was left opened)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove JMX setup by default.
If this works well, this should be set to false by default: https://github.com/jhipster/jhipster/blob/2.0.28/jhipster-framework/src/main/java/io/github/jhipster/config/JHipsterDefaults.java#L156
See #8954