Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cassandra unit tests with java 8 #8962

Merged

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Dec 16, 2018

Fixes NoClassDefFoundError: com/codahale/metrics/JmxReporter
Change benefits from the fix done for jsevellec/cassandra-unit#255

  • Please make sure the below checklist is followed for Pull Requests.

  • Travis tests are green

  • Tests are added where necessary

  • Documentation is added/updated where necessary

  • Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@DanielFran DanielFran merged commit 904a860 into jhipster:spring-boot_2.1.0 Dec 17, 2018
@DanielFran
Copy link
Member

@murdos It is still failing, but since the workaround (it was a bug in a specific cassandra version) is not needed anymore I commited it.
Thanks

@murdos murdos deleted the fix-cassandra-unit-tests-java8 branch December 17, 2018 13:09
@murdos
Copy link
Contributor Author

murdos commented Dec 17, 2018

@DanielFran What is failing? Unit tests are working fine for me with Spring Boot 2.1 + Java 8 locally.

@DanielFran
Copy link
Member

@jdubois jdubois added this to the 5.7.2 milestone Dec 21, 2018
@murdos murdos removed this from the 5.7.2 milestone Dec 23, 2018
@jdubois jdubois added this to the 5.8.0 milestone Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants