Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dependencyManagement when possible, extracted deps versions in bom #8475

Merged
merged 5 commits into from
Nov 2, 2018

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Oct 5, 2018

Opinionated way to clean the pom:

  • dependency versions has been extracted to jhipster bom (PR coming)

  • Commons Plugin configuration has been put in pluginManagement section of the pom and sorted alphabetically (at least a declaration to manage version)

  • Every plugin version has its property (some were missing)

IMHO, It will also ease pom maintenance by the jhipster community: less version duplicate, Etc.

  • [X ] Travis tests are green
  • [X ] Tests are added where necessary
  • [X ] Documentation is added/updated where necessary
  • [X ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@@ -137,7 +138,9 @@
<%_ if (!skipClient) { _%>
<sonar.testExecutionReportPaths>${project.testresult.directory}/jest/TESTS-results-sonar.xml</sonar.testExecutionReportPaths>
<%_ } _%>
<%_ if (applicationType !== 'microservice') { _%>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing with the value of skipClient (as done above on line 138) is more accurate I think, since you can generate e.g. a gateway or a monolith without the client side.

@deepu105
Copy link
Member

@Tcharl is this ready for merge?

@jdubois
Copy link
Member

jdubois commented Oct 11, 2018

Hold on, I still didn't find time to check this

@Tcharl
Copy link
Contributor Author

Tcharl commented Oct 11, 2018

jhipster/jhipster#100 need to be merged before.

@jdubois
Copy link
Member

jdubois commented Nov 2, 2018

OK I'm going to try to merge this for today's release!

@jdubois jdubois merged commit e6812b9 into jhipster:master Nov 2, 2018
@jdubois jdubois added this to the 5.6.0 milestone Nov 2, 2018
ruddell added a commit to ruddell/generator-jhipster that referenced this pull request Nov 4, 2018
@pascalgrimaud
Copy link
Member

@Tcharl : since this PR, there are some warnings in logs, specially for Microservice + Eureka. Can you have a look plz ?

[WARNING] The POM for com.github.eirslett:frontend-maven-plugin:jar:${frontend-maven-plugin.version} is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for com.github.eirslett:frontend-maven-plugin:${frontend-maven-plugin.version}: Plugin com.github.eirslett:frontend-maven-plugin:${frontend-maven-plugin.version} or one of its dependencies could not be resolved: Failure to find com.github.eirslett:frontend-maven-plugin:jar:${frontend-maven-plugin.version} in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced
[WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available
[WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failure to find org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants