-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use dependencyManagement when possible, extracted deps versions in bom #8475
Conversation
@@ -137,7 +138,9 @@ | |||
<%_ if (!skipClient) { _%> | |||
<sonar.testExecutionReportPaths>${project.testresult.directory}/jest/TESTS-results-sonar.xml</sonar.testExecutionReportPaths> | |||
<%_ } _%> | |||
<%_ if (applicationType !== 'microservice') { _%> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing with the value of skipClient (as done above on line 138) is more accurate I think, since you can generate e.g. a gateway or a monolith without the client side.
@Tcharl is this ready for merge? |
Hold on, I still didn't find time to check this |
jhipster/jhipster#100 need to be merged before. |
OK I'm going to try to merge this for today's release! |
@Tcharl : since this PR, there are some warnings in logs, specially for Microservice + Eureka. Can you have a look plz ?
|
Opinionated way to clean the pom:
dependency versions has been extracted to jhipster bom (PR coming)
Commons Plugin configuration has been put in pluginManagement section of the pom and sorted alphabetically (at least a declaration to manage version)
Every plugin version has its property (some were missing)
IMHO, It will also ease pom maintenance by the jhipster community: less version duplicate, Etc.